[OSD-6506] Refactor Account Reuse Logic

[dkeohane]

OSD-6506

• Refactored account claim parts of finaliser into an account finaliser
• Refactored chunks of AccountController reconcile loop into smaller functions
• Added some unit tests

[dastergon]

the PR has a WIP label, is that still valid?

[codecov-commenter]

Codecov Report

Merging #596 (d958eb8) into master (b732946) will increase coverage by 0.42%. The diff coverage is 14.72%.

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   19.75%   20.17%   +0.42%     
==========================================
  Files          46       46              
  Lines        4384     4426      +42     
==========================================
+ Hits          866      893      +27     
- Misses       3464     3471       +7     
- Partials       54       62       +8     

Impacted Files	Coverage Δ
pkg/controller/account/ec2.go	0.00% <0.00%> (ø)
pkg/controller/account/iam.go	54.37% <0.00%> (+0.87%)	:arrow_up:
pkg/controller/accountclaim/reuse.go	33.87% <0.00%> (-0.67%)	:arrow_down:
...ountaccess/awsfederatedaccountaccess_controller.go	0.00% <0.00%> (ø)
...controller/accountclaim/accountclaim_controller.go	8.25% <10.34%> (+0.08%)	:arrow_up:
pkg/controller/account/account_controller.go	6.38% <12.50%> (+0.55%)	:arrow_up:
pkg/controller/account/byoc.go	38.14% <83.33%> (+3.07%)	:arrow_up:
pkg/controller/utils/utils.go	47.69% <0.00%> (+3.07%)	:arrow_up:
pkg/awsclient/iam.go	18.80% <0.00%> (+4.27%)	:arrow_up:

[iamkirkbater]

/lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, dkeohane, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment