search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Ensure we validate STS AccountClaims first #598

Closed jharrington22 closed 3 years ago

jharrington22 commented 3 years ago

STS AccountClaims are entering the error state because during validate we're checking to see if credentials exist on the AccountClaim which by design wont exist for STS.

iamkirkbater commented 3 years ago

/lgtm

Once the CI jobs all finish successfully this should merge :)

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, jharrington22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater,jharrington22] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment