openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

Added Fake Account workflow #609

Closed rafael-azevedo closed 3 years ago

rafael-azevedo commented 3 years ago

This PR addes fake account workflow for Hive testing per https://issues.redhat.com/browse/OSD-7174

NautiluX commented 3 years ago

Looks good to me, but I don't have much experience with this repository, hence adding @lisa and @drpaneas as reviewer.

dastergon commented 3 years ago

@rafael-azevedo any updates here? it's a great addition.

rafael-azevedo commented 3 years ago

@rafael-azevedo any updates here? it's a great addition.

Putting in updated PR shortly with comments

codecov-commenter commented 3 years ago

Codecov Report

Merging #609 (78279d1) into master (9dd6070) will decrease coverage by 0.15%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   14.59%   14.43%   -0.16%     
==========================================
  Files          45       46       +1     
  Lines        4304     4351      +47     
==========================================
  Hits          628      628              
- Misses       3652     3698      +46     
- Partials       24       25       +1

Impacted Files	Coverage Δ
...controller/accountclaim/accountclaim_controller.go	`8.16% <0.00%> (-0.15%)`	:arrow_down:
pkg/controller/accountclaim/fake.go	`0.00% <0.00%> (ø)`

rafael-azevedo commented 3 years ago

/retest

iamkirkbater commented 3 years ago

These ran through the Make integration tests just fine. Would need to deploy to staging to test actual account creation.

rafael-azevedo commented 3 years ago

Merged Kirks PR to my branch included integration test

iamkirkbater commented 3 years ago

/lgtm

@rafael-azevedo and I paired up on Friday afternoon to include a new integration test and a verification test that runs as part of the integration suite.

iamkirkbater commented 3 years ago

/label tide/merge-method-squash /lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, iamkirkbater, rafael-azevedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment