openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Add tags to non-ccs accounts on creation #612

Closed katherinelc321 closed 3 years ago

katherinelc321 commented 3 years ago

This adds tags to non-ccs accounts on creation. This contains their respective shard names. OSD-7360

codecov-commenter commented 3 years ago

Codecov Report

Merging #612 (87bfeaf) into master (460ae6f) will increase coverage by 1.24%. The diff coverage is 37.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   13.28%   14.52%   +1.24%     
==========================================
  Files          45       45              
  Lines        3878     4325     +447     
==========================================
+ Hits          515      628     +113     
- Misses       3340     3673     +333     
- Partials       23       24       +1     
Impacted Files Coverage Δ
pkg/awsclient/client.go 0.00% <0.00%> (ø)
pkg/controller/account/account_controller.go 2.07% <45.45%> (+1.72%) :arrow_up:
pkg/apis/scheme/scheme.go 60.00% <0.00%> (-3.64%) :arrow_down:
pkg/localmetrics/localmetrics.go 52.01% <0.00%> (-1.45%) :arrow_down:
pkg/apis/aws/v1alpha1/account_types.go 89.70% <0.00%> (-0.78%) :arrow_down:
pkg/apis/apis.go 100.00% <0.00%> (ø)
cmd/manager/main.go 0.00% <0.00%> (ø)
pkg/awsclient/iam.go 0.00% <0.00%> (ø)
pkg/awsclient/tags.go 0.00% <0.00%> (ø)
... and 37 more
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drpaneas, iamkirkbater, katherinelc321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment