search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Allow the management of Route53 Resolver Endpoints and Rules #614

Closed fahlmant closed 3 years ago

fahlmant commented 3 years ago

with the network-mgmt role

https://issues.redhat.com/browse/OSD-7873

codecov-commenter commented 3 years ago

Codecov Report

Merging #614 (9fa863a) into master (011989f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   14.52%   14.52%           
=======================================
  Files          45       45           
  Lines        4325     4325           
=======================================
  Hits          628      628           
  Misses       3673     3673           
  Partials       24       24
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drpaneas, fahlmant To complete the pull request process, please assign lisa after the PR has been reviewed. You can assign the PR to them by writing /assign @lisa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iamkirkbater commented 3 years ago

/hold

There is currently ongoing discussion with the BU and CU and SREP Mgmt about the extra cost this would incur for non-ccs clusters, as well as why the current options don't meet the customer's needs.

lisa commented 3 years ago

Closing in favour of #615.