search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Rename variable and add uidLabel check #621

Closed katherinelc321 closed 3 years ago

katherinelc321 commented 3 years ago

Comments left on https://issues.redhat.com/browse/OSD-8047

codecov-commenter commented 3 years ago

Codecov Report

Merging #621 (4552624) into master (63fdf71) will increase coverage by 0.27%. The diff coverage is 54.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
+ Coverage   24.20%   24.48%   +0.27%     
==========================================
  Files          46       46              
  Lines        4457     4485      +28     
==========================================
+ Hits         1079     1098      +19     
- Misses       3304     3312       +8     
- Partials       74       75       +1
Impacted Files Coverage Δ
...ountaccess/awsfederatedaccountaccess_controller.go 4.54% <54.05%> (+4.54%) :arrow_up:
pkg/controller/account/account_controller.go 8.81% <0.00%> (-0.33%) :arrow_down:
pkg/controller/account/ec2.go 0.00% <0.00%> (ø)
iamkirkbater commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, katherinelc321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment