openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

Fixes silent failure condition on failed BYOC claim #622

Closed iamkirkbater closed 3 years ago

iamkirkbater commented 3 years ago

No card, this is the reason that #589 was failing silenty.

codecov-commenter commented 3 years ago

Codecov Report

Merging #622 (7b77669) into master (7ef100e) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   14.51%   14.51%   -0.01%     
==========================================
  Files          45       45              
  Lines        4326     4327       +1     
==========================================
  Hits          628      628              
- Misses       3674     3675       +1     
  Partials       24       24

Impacted Files	Coverage Δ
pkg/controller/account/byoc.go	`35.06% <0.00%> (-0.13%)`	:arrow_down:

lisa commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, lisa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater,lisa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment