Closed dkeohane closed 3 years ago
Merging #624 (f57abb8) into master (84b11dd) will increase coverage by
4.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 20.17% 24.20% +4.03%
==========================================
Files 46 46
Lines 4426 4457 +31
==========================================
+ Hits 893 1079 +186
+ Misses 3472 3304 -168
- Partials 61 74 +13
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/account/iam.go | 73.75% <100.00%> (+19.37%) |
:arrow_up: |
pkg/apis/aws/v1alpha1/account_types.go | 89.39% <0.00%> (-0.32%) |
:arrow_down: |
pkg/controller/account/ec2.go | 0.00% <0.00%> (ø) |
|
pkg/controller/account/account_controller.go | 9.14% <0.00%> (+2.80%) |
:arrow_up: |
pkg/controller/utils/conditions.go | 27.50% <0.00%> (+16.32%) |
:arrow_up: |
pkg/controller/utils/utils.go | 64.61% <0.00%> (+16.92%) |
:arrow_up: |
pkg/controller/account/byoc.go | 61.62% <0.00%> (+23.48%) |
:arrow_up: |
pkg/apis/aws/v1alpha1/accountclaim_types.go | 45.00% <0.00%> (+35.00%) |
:arrow_up: |
pkg/controller/utils/status.go | 91.66% <0.00%> (+45.83%) |
:arrow_up: |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dkeohane, lisa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Created a PR of some tests to expand golang testing knowledge and our test coverage for iam.go