openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

We don't need to output the error because it is expected behavior #629

Closed ArielLima closed 3 years ago

ArielLima commented 3 years ago

Card: https://issues.redhat.com/browse/OSD-7820

iamkirkbater commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArielLima, dkeohane, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov-commenter commented 3 years ago

Codecov Report

Merging #629 (29726da) into master (c761b48) will decrease coverage by 0.32%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   24.17%   23.84%   -0.33%     
==========================================
  Files          46       46              
  Lines        4464     4748     +284     
==========================================
+ Hits         1079     1132      +53     
- Misses       3311     3536     +225     
- Partials       74       80       +6

Impacted Files	Coverage Δ
pkg/controller/account/account_controller.go	`11.84% <100.00%> (+2.71%)`	:arrow_up: