openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

refactor SetAccountCondition func #630

Closed katherinelc321 closed 3 years ago

katherinelc321 commented 3 years ago

https://issues.redhat.com/browse/OSD-7694

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: katherinelc321 To complete the pull request process, please assign iamkirkbater after the PR has been reviewed. You can assign the PR to them by writing /assign @iamkirkbater in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov-commenter commented 3 years ago

Codecov Report

Merging #630 (81e22da) into master (63fdf71) will decrease coverage by 0.10%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   24.20%   24.10%   -0.11%     
==========================================
  Files          46       46              
  Lines        4457     4476      +19     
==========================================
  Hits         1079     1079              
- Misses       3304     3323      +19     
  Partials       74       74

Impacted Files	Coverage Δ
pkg/controller/utils/conditions.go	`27.67% <0.00%> (+0.17%)`	:arrow_up:
pkg/controller/account/account_controller.go	`8.96% <0.00%> (-0.18%)`	:arrow_down:
pkg/controller/account/ec2.go	`0.00% <0.00%> (ø)`

katherinelc321 commented 3 years ago

Condition.Status is already checked inside the shouldUpdateCondition() func. If we check it again it's gonna override the updateConditionCheck value we pass in