search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

[OSD-8416] Added ManagedOpenShiftSupportRole to accounts #632

Closed dkeohane closed 3 years ago

dkeohane commented 3 years ago

Ref OSD-8416: Added ManagedOpenShiftSupportRole to accounts and update SupportRoleARN in accountClaim with Role ARN

codecov-commenter commented 3 years ago

Codecov Report

Merging #632 (84ce80f) into master (097aa4b) will decrease coverage by 0.16%. The diff coverage is 14.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   24.10%   23.93%   -0.17%     
==========================================
  Files          46       46              
  Lines        4477     4554      +77     
==========================================
+ Hits         1079     1090      +11     
- Misses       3324     3387      +63     
- Partials       74       77       +3
Impacted Files Coverage Δ
pkg/controller/account/account_controller.go 8.62% <0.00%> (-0.35%) :arrow_down:
...controller/accountclaim/accountclaim_controller.go 7.96% <0.00%> (-0.35%) :arrow_down:
pkg/controller/account/iam.go 65.18% <20.96%> (-8.57%) :arrow_down:
pkg/controller/account/byoc.go 65.02% <33.33%> (+3.39%) :arrow_up:
openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkeohane, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment