Closed dkeohane closed 3 years ago
openshift-ci[bot]
commented
3 years ago Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
codecov-commenter
commented
3 years ago Merging #642 (12df26b) into master (a11fd59) will increase coverage by
2.40%. The diff coverage is46.66%.
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
+ Coverage 25.59% 28.00% +2.40%
==========================================
Files 46 46
Lines 4555 4638 +83
==========================================
+ Hits 1166 1299 +133
+ Misses 3311 3255 -56
- Partials 78 84 +6 | Impacted Files | Coverage Δ | |
|---|---|---|
| ...controller/accountclaim/accountclaim_controller.go | 9.28% <0.00%> (+0.98%) |
:arrow_up: |
| ...kg/controller/accountclaim/organizational_units.go | 85.81% <100.00%> (+66.06%) |
:arrow_up: |
| pkg/controller/account/iam.go | 65.18% <0.00%> (-8.57%) |
:arrow_down: |
| pkg/controller/account/account_controller.go | 13.48% <0.00%> (-0.30%) |
:arrow_down: |
| pkg/controller/account/byoc.go | 65.02% <0.00%> (+3.39%) |
:arrow_up: |
| ...ountaccess/awsfederatedaccountaccess_controller.go | 4.54% <0.00%> (+4.54%) |
:arrow_up: |
iamkirkbater
commented
3 years ago /lgtm
openshift-ci[bot]
commented
3 years ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dkeohane, iamkirkbater
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Ref https://issues.redhat.com/browse/OSD-8639:
We're looking to improve the stability of the AAO operator by adding more unit tests to catch potential future issue. Here are a body of unit tests to further cover ou functions.