openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

Fixes Accountpool Metric #644

Closed iamkirkbater closed 3 years ago

iamkirkbater commented 3 years ago

I did a bad and need to fix the accountpool size metric. Re-Satisfies OSD-7754

codecov-commenter commented 3 years ago

Codecov Report

Merging #644 (c34901b) into master (abdef81) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   28.80%   28.80%           
=======================================
  Files          46       46           
  Lines        4638     4638           
=======================================
  Hits         1336     1336           
  Misses       3217     3217           
  Partials       85       85

Impacted Files	Coverage Δ
pkg/localmetrics/localmetrics.go	`51.98% <0.00%> (ø)`

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment