openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Correcting some minor logging nits #646

Closed mrbarge closed 2 years ago

mrbarge commented 3 years ago

This PR addresses some minor logging nits observed where the parameters to the logging call were not being supplied in properly-balanced key/value pairs.

This fixes the following error being observed in the operator logs:

{"level":"dpanic","ts":1634650365.8639536,"logger":"controller_account","msg":"odd number of arguments passed as key-value pairs for logging", ...
codecov-commenter commented 3 years ago

Codecov Report

Merging #646 (99afb43) into master (1ec35c0) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   31.00%   31.00%           
=======================================
  Files          46       46           
  Lines        4638     4638           
=======================================
  Hits         1438     1438           
  Misses       3105     3105           
  Partials       95       95           
Impacted Files Coverage Δ
pkg/controller/account/account_controller.go 13.48% <0.00%> (ø)
dkeohane commented 3 years ago

Thanks for the fix @mrbarge !

iamkirkbater commented 2 years ago

@dkeohane can you open another PR to take care of the logging issue on line 1315?

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkeohane, iamkirkbater, mrbarge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment