openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

Document additional iam permissions for dev setup #647

Closed mrWinston closed 2 years ago

mrWinston commented 3 years ago

This PR just adds a small section to the prerequisites docs explaining the additional iam policies need to run the operator in local dev mode.

codecov-commenter commented 3 years ago

Codecov Report

Merging #647 (6ca2279) into master (1ec35c0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #647   +/-   ##
=======================================
  Coverage   31.00%   31.00%           
=======================================
  Files          46       46           
  Lines        4638     4638           
=======================================
  Hits         1438     1438           
  Misses       3105     3105           
  Partials       95       95

iamkirkbater commented 3 years ago

Can we squash this to a single commit?

mrWinston commented 3 years ago

Can we squash this to a single commit?

@iamkirkbater Done! Thanks for having a look!

dastergon commented 3 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, mrWinston, NautiluX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [NautiluX] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment