openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

[WIP] Add fedramp support #656

Closed sam-nguyen7 closed 2 years ago

sam-nguyen7 commented 2 years ago

This PR covers: OSD-9242 (Add FEDRAMP Deploy Parameter) and OSD-6798 (GovCloud Support)

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sam-nguyen7 To complete the pull request process, please assign nautilux after the PR has been reviewed. You can assign the PR to them by writing /assign @nautilux in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 2 years ago

Codecov Report

Merging #656 (c2d0c61) into master (2afa2ae) will decrease coverage by 0.82%. The diff coverage is 1.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   31.64%   30.81%   -0.83%     
==========================================
  Files          46       46              
  Lines        4601     4728     +127     
==========================================
+ Hits         1456     1457       +1     
- Misses       3047     3173     +126     
  Partials       98       98              
Impacted Files Coverage Δ
cmd/manager/main.go 0.00% <0.00%> (ø)
pkg/controller/account/account_controller.go 13.06% <0.00%> (-0.76%) :arrow_down:
pkg/controller/account/byoc.go 65.23% <0.00%> (-5.02%) :arrow_down:
...controller/accountclaim/accountclaim_controller.go 19.49% <0.00%> (-0.99%) :arrow_down:
...ountaccess/awsfederatedaccountaccess_controller.go 26.63% <0.00%> (-1.09%) :arrow_down:
...er/awsfederatedrole/awsfederatedrole_controller.go 0.00% <0.00%> (ø)
pkg/controller/utils/utils.go 60.00% <0.00%> (-4.62%) :arrow_down:
pkg/totalaccountwatcher/totalaccountwatcher.go 56.43% <0.00%> (-6.21%) :arrow_down:
pkg/controller/account/iam.go 65.27% <100.00%> (+0.09%) :arrow_up:
sam-nguyen7 commented 2 years ago

/hold

dustman9000 commented 2 years ago

/label tide/merge-method-squash

openshift-ci[bot] commented 2 years ago

@sam-nguyen7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint c2d0c614aef36da27e382514063c8c0dbededa09 link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yithian commented 2 years ago

/hold

@sam-nguyen7 i think we want to close this PR with #664 open now, right?

dastergon commented 2 years ago

Any update on this PR? Should we close in favor of the latest one?

yithian commented 2 years ago

yes, this is replaced by #664