search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

[OSD-8367] Remove references to byocadminaccess role #660

Closed dkeohane closed 2 years ago

dkeohane commented 2 years ago

Ref: OSD-8367

codecov-commenter commented 2 years ago

Codecov Report

Merging #660 (2c74c17) into master (3edeb47) will decrease coverage by 0.11%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   31.79%   31.68%   -0.12%     
==========================================
  Files          46       46              
  Lines        4651     4595      -56     
==========================================
- Hits         1479     1456      -23     
+ Misses       3069     3041      -28     
+ Partials      103       98       -5
Impacted Files Coverage Δ
pkg/controller/account/byoc.go 70.25% <ø> (+0.38%) :arrow_up:
pkg/controller/account/account_controller.go 13.81% <25.00%> (+0.40%) :arrow_up:
iamkirkbater commented 2 years ago

Tested locally. This should be good.

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkeohane, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@dkeohane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).