Closed macgregor closed 2 years ago
@macgregor: all tests passed!
Full PR test history. Your PR dashboard.
Merging #671 (2569799) into master (34f6f7a) will decrease coverage by
0.00%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 31.55% 31.54% -0.01%
==========================================
Files 47 47
Lines 4649 4650 +1
==========================================
Hits 1467 1467
- Misses 3084 3085 +1
Partials 98 98
Impacted Files | Coverage Δ | |
---|---|---|
pkg/awsclient/tags.go | 0.00% <0.00%> (ø) |
Please provide a description and a jira ticket reference
lgtm, as long as y'all are ok with hardcoding magic strings wherever :)
Please provide a description and a jira ticket reference
The jira number is in the branch name and the description is the same as the branch name, the MR title and the code comment with the change. Figured the description was pretty redundant, but I added it.
jira number is in the branch name
I wish the bot that links JIRA tickets to these PRs made that connection :( Until then, though, we have to keep adding it to the description.
The PRs here are public, however the jira cards not always so. Providing a description is necessary because not everyone knows or can see the context behind the change. There's also not always going to be a jira behind a change, so adding a description is a good regular practice
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: iamkirkbater, macgregor
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Closes OSD-7011 - provide a name for the AWS ec2 region test instances.