openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

naming the ec2 test instance that is created in each aws region #671

Closed macgregor closed 2 years ago

macgregor commented 2 years ago

Closes OSD-7011 - provide a name for the AWS ec2 region test instances.

openshift-ci[bot] commented 2 years ago

@macgregor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov-commenter commented 2 years ago

Codecov Report

Merging #671 (2569799) into master (34f6f7a) will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage   31.55%   31.54%   -0.01%     
==========================================
  Files          47       47              
  Lines        4649     4650       +1     
==========================================
  Hits         1467     1467              
- Misses       3084     3085       +1     
  Partials       98       98              
Impacted Files Coverage Δ
pkg/awsclient/tags.go 0.00% <0.00%> (ø)
fahlmant commented 2 years ago

Please provide a description and a jira ticket reference

gregsheremeta commented 2 years ago

lgtm, as long as y'all are ok with hardcoding magic strings wherever :)

macgregor commented 2 years ago

Please provide a description and a jira ticket reference

The jira number is in the branch name and the description is the same as the branch name, the MR title and the code comment with the change. Figured the description was pretty redundant, but I added it.

iamkirkbater commented 2 years ago

jira number is in the branch name

I wish the bot that links JIRA tickets to these PRs made that connection :( Until then, though, we have to keep adding it to the description.

fahlmant commented 2 years ago

The PRs here are public, however the jira cards not always so. Providing a description is necessary because not everyone knows or can see the context behind the change. There's also not always going to be a jira behind a change, so adding a description is a good regular practice

iamkirkbater commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, macgregor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment