Closed sam-nguyen7 closed 2 years ago
Merging #674 (a134492) into master (6b38815) will decrease coverage by
0.72%
. The diff coverage is0.00%
.:exclamation: Current head a134492 differs from pull request most recent head 1cc78a2. Consider uploading reports for the commit 1cc78a2 to get more accurate results
@@ Coverage Diff @@
## master #674 +/- ##
==========================================
- Coverage 31.49% 30.77% -0.73%
==========================================
Files 47 48 +1
Lines 4683 5027 +344
==========================================
+ Hits 1475 1547 +72
- Misses 3110 3373 +263
- Partials 98 107 +9
Impacted Files | Coverage Δ | |
---|---|---|
pkg/awsclient/client.go | 0.00% <0.00%> (ø) |
|
pkg/controller/account/ec2.go | 0.00% <0.00%> (ø) |
|
pkg/controller/account/account_controller.go | 13.66% <0.00%> (ø) |
|
pkg/controller/accountclaim/mock/cr-client.go | 4.25% <0.00%> (ø) |
|
pkg/localmetrics/localmetrics.go | 52.77% <0.00%> (+0.79%) |
:arrow_up: |
...controller/accountclaim/accountclaim_controller.go | 22.60% <0.00%> (+2.19%) |
:arrow_up: |
pkg/controller/accountclaim/reuse.go | 53.79% <0.00%> (+20.21%) |
:arrow_up: |
/hold
/retest
@sam-nguyen7: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: iamkirkbater, sam-nguyen7
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
On non-govcloud account the operator expects there to be a default subnet to be used when creating and terminating ec2 instances. Per https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/govcloud-ec2.html#govcloud-ec2-vpc govcloud accounts may or may not have a default subnet. Therefore, when in govcloud env, AAO needs to create a vpc, one subnet, run the ec2 instance, tear it all down.