openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Add tests for VPC Endpoint Service Configuration cleanup #677

Closed NautiluX closed 2 years ago

NautiluX commented 2 years ago

jira: OSD-10055

NautiluX commented 2 years ago

/assign @dkeohane

openshift-ci[bot] commented 2 years ago

@NautiluX: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov-commenter commented 2 years ago

Codecov Report

Merging #677 (2f630a6) into master (17d734a) will decrease coverage by 0.03%. The diff coverage is 12.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
- Coverage   31.49%   31.46%   -0.04%     
==========================================
  Files          47       48       +1     
  Lines        4683     4783     +100     
==========================================
+ Hits         1475     1505      +30     
- Misses       3110     3180      +70     
  Partials       98       98              
Impacted Files Coverage Δ
pkg/controller/accountclaim/mock/cr-client.go 4.25% <4.25%> (ø)
...controller/accountclaim/accountclaim_controller.go 21.51% <50.00%> (+1.09%) :arrow_up:
pkg/controller/accountclaim/reuse.go 41.24% <100.00%> (+7.66%) :arrow_up:
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkeohane, NautiluX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [NautiluX] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment