search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Add a check script to verify an account is under the root org. #696

Closed bergmannf closed 2 years ago

bergmannf commented 2 years ago

I didn't add an automatic move, as we will likely change AAO to no longer require accounts under the root organization soon.

codecov-commenter commented 2 years ago

Codecov Report

Merging #696 (d4489b2) into master (0dc92d1) will increase coverage by 1.49%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   30.94%   32.44%   +1.49%     
==========================================
  Files          48       48              
  Lines        5209     5542     +333     
==========================================
+ Hits         1612     1798     +186     
- Misses       3482     3611     +129     
- Partials      115      133      +18
Impacted Files Coverage Δ
...controller/accountclaim/accountclaim_controller.go 21.78% <0.00%> (-0.83%) :arrow_down:
pkg/apis/aws/v1alpha1/account_types.go 85.71% <0.00%> (+3.69%) :arrow_up:
pkg/controller/account/account_controller.go 20.85% <0.00%> (+7.40%) :arrow_up:
pkg/controller/utils/utils.go 83.07% <0.00%> (+18.46%) :arrow_up:
pkg/controller/account/account_finalizer.go 40.00% <0.00%> (+40.00%) :arrow_up:
iamkirkbater commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bergmannf, iamkirkbater, mrWinston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@bergmannf: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).