search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Reverts non-crd changes involving multiple accountpools #744

Closed iamkirkbater closed 1 year ago

iamkirkbater commented 1 year ago

This reverts the code changes for adding multiple accountpools. CRD changes were left in to avoid any potential backwards compatibility pitfalls.

iamkirkbater commented 1 year ago

/hold

we might not need this....

openshift-ci[bot] commented 1 year ago

@iamkirkbater: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov-commenter commented 1 year ago

Codecov Report

Merging #744 (e931b10) into master (1f2b896) will decrease coverage by 1.08%. The diff coverage is 6.66%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/openshift/aws-account-operator/pull/744/graphs/tree.svg?width=650&height=150&src=pr&token=u4xGTZltpx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://codecov.io/gh/openshift/aws-account-operator/pull/744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #744 +/- ## ========================================== - Coverage 39.47% 38.39% -1.08% ========================================== Files 41 41 Lines 5594 5556 -38 ========================================== - Hits 2208 2133 -75 - Misses 3192 3243 +51 + Partials 194 180 -14 ``` | [Impacted Files](https://codecov.io/gh/openshift/aws-account-operator/pull/744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [config/config.go](https://codecov.io/gh/openshift/aws-account-operator/pull/744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29uZmlnL2NvbmZpZy5nbw==) | `56.52% <ø> (-0.98%)` | :arrow_down: | | [...ontrollers/accountclaim/accountclaim\_controller.go](https://codecov.io/gh/openshift/aws-account-operator/pull/744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJvbGxlcnMvYWNjb3VudGNsYWltL2FjY291bnRjbGFpbV9jb250cm9sbGVyLmdv) | `23.30% <0.00%> (-17.10%)` | :arrow_down: | | [controllers/accountpool/accountpool\_controller.go](https://codecov.io/gh/openshift/aws-account-operator/pull/744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJvbGxlcnMvYWNjb3VudHBvb2wvYWNjb3VudHBvb2xfY29udHJvbGxlci5nbw==) | `65.00% <100.00%> (+4.56%)` | :arrow_up: |
iamkirkbater commented 1 year ago

/hold cancel

I think we still need this for the near future.

AlexVulaj commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment