search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 73 forks source link

OSD-14200 Add Max Concurrent Reconcile limit #796

Closed reedcort closed 10 months ago

reedcort commented 10 months ago

What is being added?

Adds Max Concurrent Reconcile limit field in the configmap for the accountpool validation controller

Checklist before requesting review

Ref OSD-14200

codecov-commenter commented 10 months ago

Codecov Report

Merging #796 (f5ceb6f) into master (fb85e38) will decrease coverage by 0.01%. The diff coverage is 25.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/aws-account-operator/pull/796/graphs/tree.svg?width=650&height=150&src=pr&token=u4xGTZltpx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/aws-account-operator/pull/796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #796 +/- ## ========================================== - Coverage 46.23% 46.22% -0.01% ========================================== Files 44 44 Lines 6359 6360 +1 ========================================== Hits 2940 2940 - Misses 3116 3117 +1 Partials 303 303 ``` | [Files](https://app.codecov.io/gh/openshift/aws-account-operator/pull/796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/utils/clientwrapper.go](https://app.codecov.io/gh/openshift/aws-account-operator/pull/796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL3V0aWxzL2NsaWVudHdyYXBwZXIuZ28=) | `7.93% <0.00%> (-0.13%)` | :arrow_down: | | [...rs/validation/accountpool\_validation\_controller.go](https://app.codecov.io/gh/openshift/aws-account-operator/pull/796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJvbGxlcnMvdmFsaWRhdGlvbi9hY2NvdW50cG9vbF92YWxpZGF0aW9uX2NvbnRyb2xsZXIuZ28=) | `53.46% <33.33%> (ø)` | |
openshift-ci[bot] commented 10 months ago

@reedcort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
AlexVulaj commented 10 months ago

/lgtm

iamkirkbater commented 10 months ago

/approve

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, iamkirkbater, reedcort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment