openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 73 forks source link

[OSD-19300] update account cleanup #797

Closed reedcort closed 9 months ago

reedcort commented 10 months ago

What is being added?

Is this a fix for a bug? What's the bug? Is this a new feature? Please describe it. Is this just a small typo fix? That's fine too! Update the account cleanup process to use OrgAccessRole instead of static creds.

Checklist before requesting review

[x] I have tested this locally
[x] I have included unit tests
[ ] I have updated any corresponding documentation

Ref OSD-19300

reedcort commented 10 months ago

/hold

openshift-ci[bot] commented 10 months ago

@reedcort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

reedcort commented 10 months ago

/remove-hold

AlexVulaj commented 9 months ago

/lgtm

bergmannf commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, bergmannf, reedcort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [bergmannf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment