openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

[OSD-19300-fix-typo] Fix feature flag typo #803

Closed reedcort closed 11 months ago

reedcort commented 11 months ago

What is being added?

Fixes accountclaim feature flag typo

Checklist before requesting review

Ref OSD-19300

codecov-commenter commented 11 months ago

Codecov Report

Merging #803 (77c4c0e) into master (8d7a448) will not change coverage. Report is 2 commits behind head on master. The diff coverage is 66.66%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/aws-account-operator/pull/803/graphs/tree.svg?width=650&height=150&src=pr&token=u4xGTZltpx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/aws-account-operator/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #803 +/- ## ======================================= Coverage 46.18% 46.18% ======================================= Files 44 44 Lines 6388 6388 ======================================= Hits 2950 2950 Misses 3130 3130 Partials 308 308 ``` | [Files](https://app.codecov.io/gh/openshift/aws-account-operator/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [...ontrollers/accountclaim/accountclaim\_controller.go](https://app.codecov.io/gh/openshift/aws-account-operator/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJvbGxlcnMvYWNjb3VudGNsYWltL2FjY291bnRjbGFpbV9jb250cm9sbGVyLmdv) | `57.26% <66.66%> (ø)` | |
openshift-ci[bot] commented 11 months ago

@reedcort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
iamkirkbater commented 11 months ago

/lgtm

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, reedcort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment