Closed bergmannf closed 8 months ago
I've tested updateing the resource-record with an aws CLI that is set to another region than us-east-1 and that still worked. Assuming they don't do any special handling in the CLI I hope this also works with the SDK.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
c5f00d9
) 47.77% compared to head (712606b
) 47.82%.
@bergmannf: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bergmannf, iamkirkbater
The full list of commands accepted by this bot can be found here.
The pull request process is described here
When attempting to cleanup s3 buckets in a different region than the default region it will fail otherwise.
What is being added?
Is this a fix for a bug? What's the bug? Is this a new feature? Please describe it. Is this just a small typo fix? That's fine too!
Checklist before requesting review
Steps To Manually Test
Please provide us steps to reproduce the scenarios needed to test this. If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.
Ref OSD-0000