Closed reedcort closed 6 months ago
/test integration-test
Attention: Patch coverage is 4.05405%
with 71 lines
in your changes are missing coverage. Please review.
Project coverage is 47.60%. Comparing base (
4ed85c4
) to head (eedbdab
).
/approve
@reedcort: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AlexVulaj, geowa4, reedcort
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What is being added?
Logic to support opt-in region enablement for existing accounts that are currently in a ready state
Checklist before requesting review
Steps To Manually Test
Start the operator Run "make predeploy" Set "feature.opt_in_regions" to true in hack/templates/aws.managed.openshift.io_v1alpha1_configmap.tmpl Add "opt-in-regions" entry to hack/templates/aws.managed.openshift.io_v1alpha1_configmap.tmpl Run "make create-account" Set account.Spec.accountPool to "hs-zero-size-accountpool" Verify account CR state changes to READY Verify in the AWS console that the opt-in regions specified in the configMap are enabled
Ref OSD-21097