openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

[OSD-21097] Supports Opt-In Region Enablement For existing Non-CCS Accounts #823

Closed reedcort closed 6 months ago

reedcort commented 6 months ago

What is being added?

Logic to support opt-in region enablement for existing accounts that are currently in a ready state

Checklist before requesting review

Steps To Manually Test

Start the operator Run "make predeploy" Set "feature.opt_in_regions" to true in hack/templates/aws.managed.openshift.io_v1alpha1_configmap.tmpl Add "opt-in-regions" entry to hack/templates/aws.managed.openshift.io_v1alpha1_configmap.tmpl Run "make create-account" Set account.Spec.accountPool to "hs-zero-size-accountpool" Verify account CR state changes to READY Verify in the AWS console that the opt-in regions specified in the configMap are enabled

Ref OSD-21097

reedcort commented 6 months ago

/test integration-test

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 4.05405% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 47.60%. Comparing base (4ed85c4) to head (eedbdab).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/aws-account-operator/pull/823/graphs/tree.svg?width=650&height=150&src=pr&token=u4xGTZltpx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/aws-account-operator/pull/823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #823 +/- ## ========================================== - Coverage 48.09% 47.60% -0.49% ========================================== Files 44 44 Lines 6591 6663 +72 ========================================== + Hits 3170 3172 +2 - Misses 3083 3152 +69 - Partials 338 339 +1 ``` | [Files](https://app.codecov.io/gh/openshift/aws-account-operator/pull/823?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [controllers/account/region\_enablement.go](https://app.codecov.io/gh/openshift/aws-account-operator/pull/823?src=pr&el=tree&filepath=controllers%2Faccount%2Fregion_enablement.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJvbGxlcnMvYWNjb3VudC9yZWdpb25fZW5hYmxlbWVudC5nbw==) | `53.43% <50.00%> (ø)` | | | [api/v1alpha1/account\_types.go](https://app.codecov.io/gh/openshift/aws-account-operator/pull/823?src=pr&el=tree&filepath=api%2Fv1alpha1%2Faccount_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-YXBpL3YxYWxwaGExL2FjY291bnRfdHlwZXMuZ28=) | `81.76% <0.00%> (-5.49%)` | :arrow_down: | | [...ollers/validation/account\_validation\_controller.go](https://app.codecov.io/gh/openshift/aws-account-operator/pull/823?src=pr&el=tree&filepath=controllers%2Fvalidation%2Faccount_validation_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJvbGxlcnMvdmFsaWRhdGlvbi9hY2NvdW50X3ZhbGlkYXRpb25fY29udHJvbGxlci5nbw==) | `42.50% <3.22%> (-7.21%)` | :arrow_down: |
AlexVulaj commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

@reedcort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
geowa4 commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, geowa4, reedcort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [AlexVulaj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment