Added functionality to remove EIP addresses through the shredder

openshift / aws-account-shredder

Repository to audit, service, and clean up leftover AWS resources

Apache License 2.0

9 stars 26 forks source link

Added functionality to remove EIP addresses through the shredder #46

Closed ArielLima closed 3 years ago

ArielLima commented 3 years ago

Ticket: https://issues.redhat.com/browse/OSD-5585 Since EIPs have a hard limit of 5 per account this PR releases EIPs on failed accounts so that when reused EIPs will also reset to 0

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArielLima To complete the pull request process, please assign clcollins after the PR has been reviewed. You can assign the PR to them by writing /assign @clcollins in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-shredder/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

fahlmant commented 3 years ago

Generally looks good. Please add tests

ArielLima commented 3 years ago

/label tide/merge-method-squash

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArielLima, fahlmant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-shredder/blob/master/OWNERS)~~ [fahlmant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment