search

openshift / aws-account-shredder

Repository to audit, service, and clean up leftover AWS resources
Apache License 2.0
9 stars 26 forks source link

add linters #60

Closed katherinelc321 closed 2 years ago

katherinelc321 commented 2 years ago

This PR adds linter validation and unit testing to makefile https://issues.redhat.com/browse/OSD-8597

openshift-ci[bot] commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

dastergon commented 2 years ago

@katherinelc321 can you add a description in your PR?

dastergon commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, fahlmant, katherinelc321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-shredder/blob/master/OWNERS)~~ [fahlmant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, fahlmant, katherinelc321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-shredder/blob/master/OWNERS)~~ [fahlmant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, fahlmant, katherinelc321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-shredder/blob/master/OWNERS)~~ [fahlmant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment