search

openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift
Apache License 2.0
3 stars 23 forks source link

WIP: Rework to library go #31

Closed jsafrane closed 3 years ago

jsafrane commented 3 years ago

This is preview how rewrite to library-go could look like. DO NOT MERGE!

WIP:

app-sre-bot commented 3 years ago

Can one of the admins verify this patch?

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane To complete the pull request process, please assign 2uasimojo after the PR has been reviewed. You can assign the PR to them by writing /assign @2uasimojo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 years ago

@jsafrane: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/coverage c66d65d820a09fa39f4c6d9e307314757733356e link /test coverage
ci/prow/images c66d65d820a09fa39f4c6d9e307314757733356e link /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
2uasimojo commented 3 years ago

Glanced through this. Thoughts:

openshift-ci-robot commented 3 years ago

@jsafrane: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

jsafrane commented 3 years ago

/close I am moving this to a new repo: https://github.com/openshift/aws-efs-csi-driver-operator/pull/2

openshift-ci[bot] commented 3 years ago

@jsafrane: Closed this PR.

In response to [this](https://github.com/openshift/aws-efs-operator/pull/31#issuecomment-878438721): >/close >I am moving this to a new repo: https://github.com/openshift/aws-efs-csi-driver-operator/pull/2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.