openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift
Apache License 2.0
3 stars 23 forks source link

Upgrade aws-efs-operator's 0.0.5 to support dynamic provisioning of AWS EFS #36

Closed amej closed 3 years ago

amej commented 3 years ago

AWS EFS Operator 0.0.5 provided by Red Hat is pointing towards 9 months old tag: https://quay.io/repository/app-sre/aws-efs-operator?tag=4bc180b

The existing Amazon EFS CSI driver supports dynamic provisioning.

Please upgrade the AWS EFS Operator.

2uasimojo commented 3 years ago

cf. https://coreos.slack.com/archives/CCX9DB894/p1623343446111700

2uasimojo commented 3 years ago

I think we have at least two steps available here:

  1. Bump the driver and fix up any regressions to retain functional parity with what we have today.
  2. Actually support dynamic provisioning in some way.

I can see the first thing happening. The second thing... maybe not so much, considering efforts underway to ship an officially-supported build of the driver with OCP.

jharrington22 commented 3 years ago

Yes I'd agree that 1 is a possibility and for 2 I'd have to look at what the new driver is providing and if we consider it to be feature complete with what we'd expect from dynamic provisioning and OSD. We also need to consider OSD documentation updates etc.

As @2uasimojo said there is work from OCP to ship an officially support version of the driver with OCP.

amej commented 3 years ago

Yes I'd agree that 1 is a possibility and for 2 I'd have to look at what the new driver is providing and if we consider it to be feature complete with what we'd expect from dynamic provisioning and OSD. We also need to consider OSD documentation updates etc.

I installed this driver https://github.com/kubernetes-sigs/aws-efs-csi-driver/tree/release-1.3 within my company's OSD account.
EFS Filesystems had to be pre-created. Upon creation of the Openshift PVC; the EFS access point got automatically created within the EFS filesystem.

I am interested to understand the highlights of the complete feature set expected from dynamic provisioning offered in the OSD.

2uasimojo commented 3 years ago

Here's the RFE for including the driver in OCP: https://github.com/openshift/enhancements/pull/687

To my understanding, that just gets you... the driver. You would have to do the rest manually as you described above.

amej commented 3 years ago

Thank you. I am closing this issue and keeping track of my request in https://github.com/openshift/enhancements/pull/687