search

openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift
Apache License 2.0
3 stars 23 forks source link

Update k8s storage CSI Driver API to v1 #44

Closed jharrington22 closed 2 years ago

jharrington22 commented 2 years ago

Update k8s storage CSI Driver API to v1

New storage CSI driver required k8s deps upgrade to at least 0.18.0 which was completed in #43.

Tested operator new CSI driver version on OCP 4.9.6

oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.9.6     True        False         166m    Cluster version is 4.9.6

Operator logs for verification

{"level":"info","ts":1639782530.9271128,"logger":"cmd","msg":"Operator Version: 0.0.1"}
{"level":"info","ts":1639782530.9272738,"logger":"cmd","msg":"Go Version: go1.16"}                                                                                                  
{"level":"info","ts":1639782530.9273074,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}                                                                                             {"level":"info","ts":1639782530.9273217,"logger":"cmd","msg":"Version of operator-sdk: v0.18.2"}                                                                                    
{"level":"info","ts":1639782530.9278007,"logger":"leader","msg":"Trying to become the leader."}                                                                                     I1217 23:08:51.978592       1 request.go:645] Throttling request took 1.039338026s, request: GET:https://172.30.0.1:443/apis/config.openshift.io/v1?timeout=32s                     
{"level":"info","ts":1639782533.6922016,"logger":"leader","msg":"No pre-existing lock was found."}                                                                                  
{"level":"info","ts":1639782533.698035,"logger":"leader","msg":"Became the leader."}                                                                                                
{"level":"info","ts":1639782536.45349,"logger":"controller-runtime.metrics","msg":"metrics server is starting to listen","addr":"0.0.0.0:8383"}                                     {"level":"info","ts":1639782536.4538062,"logger":"cmd","msg":"Registering Components."}                                                                                             
{"level":"info","ts":1639782539.2111015,"logger":"cmd","msg":"Found. Checking whether update is needed.","resource":{"namespace":"openshift-operators","name":"efs-csi-sa"}}        {"level":"info","ts":1639782539.2111475,"logger":"cmd","msg":"No update needed."}                                                                                                   
{"level":"info","ts":1639782539.2151961,"logger":"cmd","msg":"Found. Checking whether update is needed.","resource":{"name":"efs-csi-scc"}}                                         
{"level":"info","ts":1639782539.2153044,"logger":"cmd","msg":"No update needed."}                                                                                                   {"level":"info","ts":1639782539.2248325,"logger":"cmd","msg":"Found. Checking whether update is needed.","resource":{"namespace":"openshift-operators","name":"efs-csi-node"}}      
{"level":"info","ts":1639782539.2249322,"logger":"cmd","msg":"Update needed. Updating..."}                                                                                          {"level":"info","ts":1639782539.2336543,"logger":"cmd","msg":"Updated.","resource":{"namespace":"openshift-operators","name":"efs-csi-node"}}                                       
{"level":"info","ts":1639782539.2360437,"logger":"cmd","msg":"Creating.","resource":{"name":"efs.csi.aws.com"}}                                                                     
{"level":"info","ts":1639782539.2415602,"logger":"cmd","msg":"Created.","resource":{"name":"efs.csi.aws.com"}}                                                                      
{"level":"info","ts":1639782539.2441304,"logger":"cmd","msg":"Found. Checking whether update is needed.","resource":{"name":"efs-sc"}}                                              
{"level":"info","ts":1639782539.2441738,"logger":"cmd","msg":"No update needed."}                                                                                                   
I1217 23:09:01.995588       1 request.go:645] Throttling request took 2.74719813s, request: GET:https://172.30.0.1:443/apis/metal3.io/v1alpha1?timeout=32s                          
{"level":"info","ts":1639782544.768186,"logger":"metrics","msg":"Metrics Service object created","Service.Name":"aws-efs-operator-metrics","Service.Namespace":"openshift-operators"
}
{"level":"info","ts":1639782547.5327375,"logger":"cmd","msg":"Starting the Cmd."}
{"level":"info","ts":1639782547.5329247,"logger":"controller-runtime.manager","msg":"starting metrics server","path":"/metrics"}
{"level":"info","ts":1639782547.5329683,"logger":"controller","msg":"Starting EventSource","controller":"sharedvolume-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782547.5329897,"logger":"controller","msg":"Starting EventSource","controller":"statics-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782547.633707,"logger":"controller","msg":"Starting EventSource","controller":"sharedvolume-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782547.634364,"logger":"controller","msg":"Starting EventSource","controller":"statics-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782547.734494,"logger":"controller","msg":"Starting EventSource","controller":"sharedvolume-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782547.7346046,"logger":"controller","msg":"Starting EventSource","controller":"statics-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782547.8354259,"logger":"controller","msg":"Starting Controller","controller":"sharedvolume-controller"}
{"level":"info","ts":1639782547.8354814,"logger":"controller","msg":"Starting workers","controller":"sharedvolume-controller","worker count":1}
{"level":"info","ts":1639782547.8354268,"logger":"controller","msg":"Starting EventSource","controller":"statics-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782547.935819,"logger":"controller","msg":"Starting EventSource","controller":"statics-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1639782548.03626,"logger":"controller","msg":"Starting Controller","controller":"statics-controller"}
{"level":"info","ts":1639782548.0363014,"logger":"controller","msg":"Starting workers","controller":"statics-controller","worker count":1}

Tested created a SharedVolume resource

oc get pvc -n james                                               
NAME      STATUS   VOLUME         CAPACITY   ACCESS MODES   STORAGECLASS   AGE
pvc-sv1   Bound    pv-james-sv1   1Gi        RWX            efs-sc         36s
dustman9000 commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, jharrington22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)~~ [dustman9000,jharrington22] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@jharrington22: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov-commenter commented 2 years ago

Codecov Report

Merging #44 (28a34f8) into master (043676e) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files          21       21           
  Lines         688      688           
=======================================
  Hits          524      524           
  Misses        157      157           
  Partials        7        7
Impacted Files Coverage Δ
pkg/controller/statics/statics.go 84.46% <100.00%> (ø)