openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift

Apache License 2.0

3 stars 23 forks source link

enables FIPS build #46

Closed wanghaoran1988 closed 2 years ago

wanghaoran1988 commented 2 years ago

SDE-1954 This is for FedRAMP change control purposes

codecov-commenter commented 2 years ago

Codecov Report

Merging #46 (9a2a91c) into master (9c87267) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files          21       21           
  Lines         688      688           
=======================================
  Hits          524      524           
  Misses        157      157           
  Partials        7        7

wanghaoran1988 commented 2 years ago

It's failed because it's using golang1.13 not the boilerplate builder image, here is the fix: https://github.com/openshift/release/pull/28907

2uasimojo commented 2 years ago

:eyes:

2uasimojo commented 2 years ago

/retest

2uasimojo commented 2 years ago

(Note that this repo still hasn't been properly onboarded to use standardized release config -- see https://issues.redhat.com/browse/OSD-5653.)

openshift-ci[bot] commented 2 years ago

@wanghaoran1988: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

2uasimojo commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, wanghaoran1988

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)~~ [2uasimojo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment