search

openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift
Apache License 2.0
3 stars 23 forks source link

preview golangci gosec lint in aws-efs-operator #47

Closed reetika-vyas closed 2 years ago

reetika-vyas commented 2 years ago

added the error handling flagged by gosec for aws-efs-operator

openshift-ci[bot] commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reetika-vyas To complete the pull request process, please assign 2uasimojo after the PR has been reviewed. You can assign the PR to them by writing /assign @2uasimojo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
reetika-vyas commented 2 years ago

In several of the places where you've added error checking, there are comments explaining why error checking was previously absent. At least in those places, suggest finding a less disruptive way around gosec. For example, perhaps instead of returning the error, simply log it and proceed?

I made the changes you requested