Closed reetika-vyas closed 2 years ago
/test coverage
The coverage failure red-flagged me into looking a bit deeper here.
I don't think we can move forward with this work (enabling gosec
) until we've addressed (at least part of) the remainder of OSD-5653. Specifically for this work, we should add the lint
CI target. That should be as simple as adding a chunk like this to the release config for aws-efs-operator. That way lint-related changes will be validated by CI, which isn't happening currently.
Once that's done, I think we'll find that there are already some linting issues to be addressed before we even get to gosec
.
@reetika-vyas: all tests passed!
Full PR test history. Your PR dashboard.
/assign @2uasimojo Can you give this another round of review?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 2uasimojo, reetika-vyas
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Solved gosec issues with error handling on repo