search

openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift
Apache License 2.0
3 stars 23 forks source link

enabled gosec for aws-efs-operator #48

Closed reetika-vyas closed 2 years ago

reetika-vyas commented 2 years ago

Solved gosec issues with error handling on repo

reetika-vyas commented 2 years ago

/test coverage

2uasimojo commented 2 years ago

The coverage failure red-flagged me into looking a bit deeper here.

I don't think we can move forward with this work (enabling gosec) until we've addressed (at least part of) the remainder of OSD-5653. Specifically for this work, we should add the lint CI target. That should be as simple as adding a chunk like this to the release config for aws-efs-operator. That way lint-related changes will be validated by CI, which isn't happening currently.

Once that's done, I think we'll find that there are already some linting issues to be addressed before we even get to gosec.

openshift-ci[bot] commented 2 years ago

@reetika-vyas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
supreeth7 commented 2 years ago

/assign @2uasimojo Can you give this another round of review?

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, reetika-vyas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)~~ [2uasimojo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment