search

openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift
Apache License 2.0
3 stars 23 forks source link

Boilerplate: Subscribe at a48d90919cb9a4fe3b4bbd51ac6ef71ea1b49ed6 #53

Closed tnierman closed 9 months ago

tnierman commented 9 months ago

https://issues.redhat.com/browse/OSD-18002

Conventions:

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tnierman Once this PR has been reviewed and has the lgtm label, please assign jharrington22 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9c87267) 76.16% compared to head (70f8e8a) 89.02%. Report is 5 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/aws-efs-operator/pull/53/graphs/tree.svg?width=650&height=150&src=pr&token=U7CGIMUTH4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/aws-efs-operator/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #53 +/- ## =========================================== + Coverage 76.16% 89.02% +12.85% =========================================== Files 21 15 -6 Lines 688 583 -105 =========================================== - Hits 524 519 -5 + Misses 157 56 -101 - Partials 7 8 +1 ``` | [Files](https://app.codecov.io/gh/openshift/aws-efs-operator/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/controller/statics/statics\_controller.go](https://app.codecov.io/gh/openshift/aws-efs-operator/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvc3RhdGljcy9zdGF0aWNzX2NvbnRyb2xsZXIuZ28=) | `74.00% <100.00%> (ø)` | | | [pkg/test/helpers.go](https://app.codecov.io/gh/openshift/aws-efs-operator/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL3Rlc3QvaGVscGVycy5nbw==) | `38.46% <100.00%> (+5.12%)` | :arrow_up: | | [...controller/sharedvolume/sharedvolume\_controller.go](https://app.codecov.io/gh/openshift/aws-efs-operator/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvc2hhcmVkdm9sdW1lL3NoYXJlZHZvbHVtZV9jb250cm9sbGVyLmdv) | `85.31% <60.00%> (-0.98%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/openshift/aws-efs-operator/pull/53/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 9 months ago

@tnierman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 70f8e8abbe8c330fbdd9711de48d165753861734 link true /test lint
ci/prow/images 70f8e8abbe8c330fbdd9711de48d165753861734 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tnierman commented 9 months ago

/close

openshift-ci[bot] commented 9 months ago

@tnierman: Closed this PR.

In response to [this](https://github.com/openshift/aws-efs-operator/pull/53#issuecomment-1881916120): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.