2uasimojo commented 4 years ago

This is a rollup of work to make the operator build, CI check, and deploy.

Renames for repo move

The name of the operator in the 2uasimojo-owned scratch repo was efs-csi-operator. It is now aws-efs-operator in the openshift-owned repo.

Port in standard make stuff

Pending boilerplate standardization of such things, this commit copies in project.mk and standard.mk from the aws-account-operator and/or certman-operator repositories, merging/adapting the differences as appropriate.

We also bring in the standard coverage target and utility per this SOP, which prompted a few tweaks to ensure generated files are ignored in the reports. The cover target is renamed coverhtml and refactored to use the results of coverage.

The gofmt command is tweaked to (again) ignore generated files. And since it was getting a bit unwieldy for a single line in a make target, it's peeled out into a new helper script. Source files are modified to make linting happy.

2uasimojo commented 4 years ago

/test ci/prow/coverage

openshift-ci-robot commented 4 years ago

@2uasimojo: The specified target(s) for /test were not found. The following commands are available to trigger jobs:

/test coverage
/test images

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/aws-efs-operator/pull/7#issuecomment-637175226): >/test ci/prow/coverage > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

2uasimojo commented 4 years ago

/test coverage

2uasimojo commented 4 years ago

/test coverage

2uasimojo commented 4 years ago

/test coverage

2uasimojo commented 4 years ago

/test coverage

2uasimojo commented 4 years ago

/test coverage

jharrington22 commented 4 years ago

/test coverage

jharrington22 commented 4 years ago

/test coverage

2uasimojo commented 4 years ago

/test coverage

2uasimojo commented 4 years ago

/test coverage

codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@01ec91a). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   75.52%           
=========================================
  Files             ?       18           
  Lines             ?      617           
  Branches          ?        0           
=========================================
  Hits              ?      466           
  Misses            ?      144           
  Partials          ?        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01ec91a...47adcb0. Read the comment docs.

jharrington22 commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, jharrington22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)~~ [2uasimojo,jharrington22] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

droslean commented 4 years ago

/refresh /test all

2uasimojo commented 4 years ago

/refresh

2uasimojo commented 4 years ago

/test all

openshift / aws-efs-operator

Deployment artifacts #7

Codecov Report