openshift / aws-efs-operator

Operator to manage AWS EFS on OpenShift
Apache License 2.0
3 stars 23 forks source link

More Deployment Fixes #8

Closed 2uasimojo closed 4 years ago

2uasimojo commented 4 years ago
codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0c5a865). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   74.11%           
=========================================
  Files             ?       18           
  Lines             ?      618           
  Branches          ?        0           
=========================================
  Hits              ?      458           
  Misses            ?      153           
  Partials          ?        7           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c5a865...91237be. Read the comment docs.

jharrington22 commented 4 years ago

@2uasimojo you can add -nometadata to the generate bin data to remove timestamps.

dustman9000 commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dustman9000, jharrington22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-efs-operator/blob/master/OWNERS)~~ [2uasimojo,dustman9000,jharrington22] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
2uasimojo commented 4 years ago

@2uasimojo you can add -nometadata to the generate bin data to remove timestamps.

Done via https://github.com/openshift/aws-efs-operator/pull/10