search

openshift / backplane-tools

Manages the tools needed to interact with clusters
Apache License 2.0
4 stars 28 forks source link

start inheritance for tool objects #29

Closed Tof1973 closed 10 months ago

Tof1973 commented 10 months ago

This PR starts to implement the inheritance for backplane-tools definition, knowing we will be able also to simplify also install functions. It also implements the version management, as it is much easier to do it with inheritance in place ;)

tnierman commented 10 months ago

/hold

for discussion

Nikokolas3270 commented 10 months ago

/lgtm

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Nikokolas3270, Tof1973, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/backplane-tools/blob/main/OWNERS)~~ [typeid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 10 months ago

@Tof1973: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
typeid commented 10 months ago

Happy to unhold and merge this WDYT @tnierman?

tnierman commented 10 months ago

/label tide/merge-method-squash

tnierman commented 10 months ago

FANTASTIC WORK @Tof1973

/unhold /lgtm /honk

openshift-ci[bot] commented 10 months ago

@tnierman: goose image

In response to [this](https://github.com/openshift/backplane-tools/pull/29#issuecomment-1836454127): >FANTASTIC WORK @Tof1973 > >/unhold >/lgtm >/honk Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.