openshift / backplane-tools

Manages the tools needed to interact with clusters
Apache License 2.0
4 stars 28 forks source link

Unify file creation procedure #46

Closed tnierman closed 8 months ago

tnierman commented 8 months ago

Unifies the various file creation portions into a single pkg/utils function for consistency & simplicity.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnierman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/backplane-tools/blob/main/OWNERS)~~ [tnierman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 8 months ago

@tnierman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rendhalver commented 8 months ago

Cool. I have been pondering how we might make the symlinks to latest relative so this well help a lot there. :)

clcollins commented 8 months ago

/lgtm