openshift / backplane-tools

Manages the tools needed to interact with clusters
Apache License 2.0
4 stars 28 forks source link

Updates the error message for installing tools #67

Closed iamkirkbater closed 6 months ago

iamkirkbater commented 6 months ago

Adds a better error output for this step, changing from:

Installing the following tools:
- servicelogger v0.1.1
- aws 2.15.34
- oc 4.15.3
- butane v0.20.0
Error: failed to locate latest archive matching system spec: unexpected number of assets found matching system spec: expected at least 1, got 0

to

Installing the following tools:
- servicelogger v0.1.1
- aws 2.15.34
- oc 4.15.3
- butane v0.20.0
Error: unable to install the latest version of osdctl: failed to locate latest archive matching system spec: unexpected number of assets found matching system spec: expected at least 1, got 0

This way you can at least see as the end user if it's the same package that's failing to install.

openshift-ci[bot] commented 6 months ago

@iamkirkbater: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
AlexVulaj commented 6 months ago

/lgtm

tnierman commented 6 months ago

/label tide/merge-method-squash /lgtm

tnierman commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, tnierman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/backplane-tools/blob/main/OWNERS)~~ [tnierman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment