search

openshift / backplane-tools

Manages the tools needed to interact with clusters
Apache License 2.0
4 stars 28 forks source link

Update arch aliases for Mac ARM series #71

Closed devppratik closed 4 months ago

devppratik commented 4 months ago

This PR adds arch aliases - arm64 & arm for ARM64. This is because some binaries like gcloud do not have arm64 in the binary name, which was causing issues for installation.

Relevant discussion - https://redhat-internal.slack.com/archives/C04PUGBE7JN/p1716351644144979

Before the change

❯ backplane-tools install gcloud
Installing the following tools:
Error: failed to locate latest archive matching system spec: unexpected number of assets found matching system spec: expected at least 1, got 0
Usage:
  backplane-tools install [all|backplane-tools|oc|rosa|yq|butane|servicelogger|aws|ocm|ocm-addons|osdctl|backplane-cli|gcloud] [flags]

Flags:
  -h, --help   help for install

2024/05/22 10:35:49 Error executing command: failed to locate latest archive matching system spec: unexpected number of assets found matching system spec: expected at least 1, got 0

After the change

❯ ./backplane-tools install gcloud               
Installing the following tools:
- gcloud google-cloud-cli-477.0.0-darwin-arm

Installing gcloud
Successfully installed gcloud
openshift-ci[bot] commented 4 months ago

@devppratik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
samanthajayasinghe commented 4 months ago

/lgtm

tnierman commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devppratik, tnierman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/backplane-tools/blob/main/OWNERS)~~ [tnierman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment