openshift / boilerplate

Standardize conventions used for development and tooling across repositories
Apache License 2.0
14 stars 69 forks source link

fix: quotes preventing expansion #440

Closed jbpratt closed 4 weeks ago

jbpratt commented 4 weeks ago
...
++ mktemp -d
+ BP_CLONE=/tmp/tmp.1P95PaSBNN
+ [[ -z '' ]]
+ git clone -b konflux-swapover git@github.com:jbpratt/boilerplate.git /tmp/tmp.1P95PaSBNN
Cloning into '/tmp/tmp.1P95PaSBNN'...
remote: Enumerating objects: 4473, done.
remote: Counting objects: 100% (792/792), done.
...
mmazur commented 4 weeks ago

/lgtm

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, mmazur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/boilerplate/blob/master/OWNERS)~~ [mmazur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 weeks ago

@jbpratt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).