openshift / boilerplate

Standardize conventions used for development and tooling across repositories
Apache License 2.0
14 stars 69 forks source link

[OSD-26766] removes leading g before comparing short_hash to DEPLOYED_HASH #474

Closed bng0y closed 2 days ago

bng0y commented 6 days ago

Since https://github.com/openshift/boilerplate/pull/373, we added a leading g character in the short_hash of our operators' bundle name. Unfortunately, this short hash is used to cleanup non-promoted commits on the production channel. As a result, any operator promotion will be achieved by incrementing through every commit. This means that a bad commit will require a OLM dance to unblock the upgrade.

This PR removes the leading character (g) when the length of short_hash is greater than 7. from boilerplate/openshift/golang-osd-operator/standard.mk, short_hash are currently 8 character long (g + 7 first chars of the commit hash)

jbpratt commented 5 days ago

/lgtm

openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bng0y, jbpratt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/boilerplate/blob/master/OWNERS)~~ [bng0y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jbpratt commented 4 days ago

/tide

jbpratt commented 2 days ago

/tide /ok-to-test

openshift-ci[bot] commented 2 days ago

@bng0y: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).