search

openshift / builder

The image run by build pods to execute image building+pushing
Apache License 2.0
31 stars 50 forks source link

OCPBUGS-22497: Add -p flag to cp command to preserve timestamps #369

Closed coreydaley closed 11 months ago

openshift-ci-robot commented 11 months ago

@coreydaley: This pull request references Jira Issue OCPBUGS-22497, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/builder/pull/369): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 11 months ago

/jira refresh

openshift-ci-robot commented 11 months ago

@coreydaley: This pull request references Jira Issue OCPBUGS-22497, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @coreydaley

In response to [this](https://github.com/openshift/builder/pull/369#issuecomment-1797374840): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: coreydaley.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/builder/pull/369#issuecomment-1797375122): >@coreydaley: This pull request references [Jira Issue OCPBUGS-22497](https://issues.redhat.com//browse/OCPBUGS-22497), which is valid. The bug has been moved to the POST state. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.15.0) matches configured target version for branch (4.15.0) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @coreydaley

In response to [this](https://github.com/openshift/builder/pull/369#issuecomment-1797374840): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coreydaley commented 11 months ago

/assign @nalind /cherry-pick release-4.14

openshift-cherrypick-robot commented 11 months ago

@coreydaley: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/builder/pull/369#issuecomment-1797377039): >/assign @nalind >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 11 months ago

/label px-approved /label docs-approved /label qe-approved

coreydaley commented 11 months ago

/retest

openshift-ci-robot commented 11 months ago

@coreydaley: This pull request references Jira Issue OCPBUGS-22497, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (cdaley@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/builder/pull/369): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coreydaley commented 11 months ago

/assign @divyansh42 @apoorvajagtap @ayushsatyam146

divyansh42 commented 11 months ago

/lgtm

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, divyansh42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/builder/blob/master/OWNERS)~~ [coreydaley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 11 months ago

@coreydaley: Jira Issue OCPBUGS-22497: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22497 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/builder/pull/369): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

@coreydaley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f26ecced50e58b4a554289b2b95d9520bf8d37b9 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-cherrypick-robot commented 11 months ago

@coreydaley: new pull request created: #370

In response to [this](https://github.com/openshift/builder/pull/369#issuecomment-1797377039): >/assign @nalind >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.