search

openshift / builder

The image run by build pods to execute image building+pushing
Apache License 2.0
31 stars 50 forks source link

OCPBUGS-32844: bump go-jose to fix CVE-2024-28180 #398

Open avinal opened 3 months ago

avinal commented 3 months ago

Changes

Signed-off-by: Avinal Kumar avinal@redhat.com

Release note

CVE-2024-28180: Upgrade go-jose to mitigate potential denial of service attacks.
openshift-ci-robot commented 3 months ago

@avinal: This pull request references Jira Issue OCPBUGS-32844, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/builder/pull/398): >## Changes > >- Bump gopkg.in/go-jose/go-jose.v2 to 2.6.3 > >Signed-off-by: Avinal Kumar > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fbuilder). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
avinal commented 3 months ago

/jira-refresh

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avinal Once this PR has been reviewed and has the lgtm label, please assign sayan-biswas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/builder/blob/release-4.14/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
avinal commented 3 months ago

/retest

openshift-ci-robot commented 3 months ago

@avinal: This pull request references Jira Issue OCPBUGS-32844, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/builder/pull/398): >## Changes > >- gopkg.in/square/go-jose.v2 has been deprecated >- replacing with equivalent gopkg.in/go-jose/go-jose.v2 causes multiple > imports issue >- replaced with security release github.com/go-jose/go-jose v2.6.3 >- fixes https://github.com/advisories/GHSA-c5q2-7r4c-mv6g > >Signed-off-by: Avinal Kumar > >## Release note > >```release-note >CVE-2024-28180: Upgrade go-jose to mitigate potential denial of service attacks. >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fbuilder). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
avinal commented 3 months ago

/retest

adambkaplan commented 3 months ago

Is this blocked by https://github.com/openshift/origin/pull/28904 and its cherry-picks?

adambkaplan commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@adambkaplan: This pull request references Jira Issue OCPBUGS-32844, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/builder/pull/398#issuecomment-2217546646): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fbuilder). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
avinal commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@avinal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 121582b214a14e7c362f19570c833ccaa1b3fd74 link false /test security
ci/prow/e2e-aws-ovn-builds-techpreview 121582b214a14e7c362f19570c833ccaa1b3fd74 link false /test e2e-aws-ovn-builds-techpreview
ci/prow/e2e-aws-ovn-builds 121582b214a14e7c362f19570c833ccaa1b3fd74 link true /test e2e-aws-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).