openshift / check-payload

Apache License 2.0
12 stars 35 forks source link

Config validation fixups #108

Closed kolyshkin closed 1 year ago

kolyshkin commented 1 year ago

With this fix, the config validation now properly detects the dupe that was fixed earlier in commit a8c7f00 / PR #106 (which it failed to detect before).

With that commit reverted, the failure looks like this:

=== RUN TestConfigs config_test.go:47: main+4.13 combined config failed validation: errors: ; warnings: config entry [[rpm.containernetworking-plugins.ignore]].error=ErrGoMissingTag.files contains a redundant path "/usr/libexec/cni/dummy", overlapped by "/usr/libexec/cni" --- FAIL: TestConfigs (0.00s)

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/check-payload/blob/main/OWNERS)~~ [kolyshkin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@kolyshkin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 1 year ago

/lgtm