openshift / check-payload

Apache License 2.0
10 stars 28 forks source link

config.toml: add exception for rukpak #117

Closed kolyshkin closed 9 months ago

kolyshkin commented 9 months ago

Joe Lanford says:

We copy this binary into a scratch image, so it needs to be statically compiled. It does not do any crypto.

Since this binary will also be in a future releases, place it in a global config.

Tested with:

$ ./check-payload scan payload -u registry.ci.openshift.org/ocp/release:4.14.0-0.nightly-2023-09-21-002530 -V 4.14
...
---- Successful run
openshift-ci[bot] commented 9 months ago

@kolyshkin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/check-payload/blob/main/OWNERS)~~ [kolyshkin,mrunalp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment