search

openshift / check-payload

Apache License 2.0
12 stars 35 forks source link

exclude a statically-compiled utility for OLM #118

Closed stevekuznetsov closed 1 year ago

stevekuznetsov commented 1 year ago

In 4.15+, OLM will not require that users provide an opm binary with their index image. In cases where they do not, OLM simply copies the catalog data from their index image and uses it directly. In order to copy this data, we do not want to assume anything about the image that contains the content we need to copy, so we statically compile a utility that helps us copy the data around, instead of assuming the image has sh or cp.

stevekuznetsov commented 1 year ago

https://github.com/operator-framework/operator-lifecycle-manager/issues/3019

rphillips commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, mrunalp, rphillips, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/check-payload/blob/main/OWNERS)~~ [kolyshkin,mrunalp,rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment