openshift / check-payload

Apache License 2.0
10 stars 28 forks source link

Add exceptions for OpenShift Virtualisation #174

Closed dominikholler closed 2 months ago

rphillips commented 2 months ago

@dominikholler Can you provide a link to the dockerfiles?

dominikholler commented 2 months ago

@dominikholler perhaps it's better to add this into global config instead? This will result in 4x decrease in amount of lines added :)

Thanks, I did not recognize that this is possible before!

dominikholler commented 2 months ago

@dominikholler Can you provide a link to the dockerfiles?

https://catalog.redhat.com/software/containers/container-native-virtualization/virt-cdi-importer-rhel9/633ffae45e9aa29cb935ca72?architecture=amd64&image=6601ae2c16b1b63a2fb91a41&container-tabs=dockerfile

https://catalog.redhat.com/software/containers/container-native-virtualization/virt-launcher-rhel9/633ffae66804229d44d4c75a?architecture=amd64&image=65eb469817260331dcb562ef

openshift-ci[bot] commented 2 months ago

@dominikholler: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 2 months ago

/lgtm /assign @rhmdnd

openshift-ci[bot] commented 2 months ago

@rphillips: GitHub didn't allow me to assign the following users: rhmdnd.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openshift/check-payload/pull/174#issuecomment-2075140624): >/lgtm >/assign @rhmdnd Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dominikholler, kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/check-payload/blob/main/OWNERS)~~ [kolyshkin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment